ci: unit & ui testing #6
Conversation
also: - migrate react-app to vite - remove react-scripts - common prettier config
|
@emagnier @tukusejssirs if you wouldn't mind approving the workflow run when you have time and reviewing, I think this covers most of our UI testing needs |
There was a problem hiding this comment.
Hey @TobiTenno, I haven't looked at everything closely, but thanks for your work!
|
@emagnier or @tukusejssirs could we turn on the checks i'm adding in this PR as required and enable actions for this repo? |
|
I'm ok to enable what's needed. @TobiTenno, I've just made you an admin on romcal-examples and romcal.github.io, so you can organize things more freely in order to fine-tune the workflow, branches, and deployment settings as necessary. |
|
FYI, you're also an admin on the main romcal repo. I trust you completely, and it'll be easier for you to make progress more efficiently on all the scaffolding and setting up the things for romcal. |
There was a problem hiding this comment.
There are some nitpicks that could be solved at your discretion, @TobiTenno, however, otherwise you have done a great job! 🙏
You can disregard my comments and/or consider working on them in separate PRs. 😉
resolve several commits
use port better in cypress tests
|
@TobiTenno, see my latest comments. I agree with everything you did and thank you for implementing of my suggestions! 🙏 |
also:
closes #4
closes #7