chore: promote rules

rome · Oct 26, 2022 · fec25a9 · fec25a9
1 parent 533a7b2
commit fec25a9
Show file tree

Hide file tree

Showing 129 changed files with 1,885 additions and 1,289 deletions.
diff --git a/crates/rome_diagnostics_categories/src/categories.rs b/crates/rome_diagnostics_categories/src/categories.rs
@@ -15,48 +15,51 @@ define_dategories! {
     "lint/correctness/noCatchAssign": "https://rome.tools/docs/lint/rules/noCatchAssign",
     "lint/correctness/noCommentText": "https://rome.tools/docs/lint/rules/noCommentText",
     "lint/correctness/noCompareNegZero": "https://rome.tools/docs/lint/rules/noCompareNegZero",
-    "lint/correctness/noDebugger": "https://rome.tools/docs/lint/rules/noDebugger",
     "lint/correctness/noDelete": "https://rome.tools/docs/lint/rules/noDelete",
     "lint/correctness/noDoubleEquals": "https://rome.tools/docs/lint/rules/noDoubleEquals",
     "lint/correctness/noDupeArgs": "https://rome.tools/docs/lint/rules/noDupeArgs",
     "lint/correctness/noEmptyPattern": "https://rome.tools/docs/lint/rules/noEmptyPattern",
     "lint/correctness/noFunctionAssign": "https://rome.tools/docs/lint/rules/noFunctionAssign",
-    "lint/correctness/noImplicitBoolean": "https://rome.tools/docs/lint/rules/noImplicitBoolean",
     "lint/correctness/noImportAssign": "https://rome.tools/docs/lint/rules/noImportAssign",
     "lint/correctness/noLabelVar": "https://rome.tools/docs/lint/rules/noLabelVar",
     "lint/correctness/noMultipleSpacesInRegularExpressionLiterals": "https://rome.tools/docs/lint/rules/noMultipleSpacesInRegularExpressionLiterals",
     "lint/correctness/noShadowRestrictedNames": "https://rome.tools/docs/lint/rules/noShadowRestrictedNames",
     "lint/correctness/noSparseArray": "https://rome.tools/docs/lint/rules/noSparseArray",
     "lint/correctness/noUnnecessaryContinue": "https://rome.tools/docs/lint/rules/noUnnecessaryContinue",
     "lint/correctness/noUnsafeNegation": "https://rome.tools/docs/lint/rules/noUnsafeNegation",
-    "lint/correctness/noUnusedTemplateLiteral": "https://rome.tools/docs/lint/rules/noUnusedTemplateLiteral",
-    "lint/correctness/useBlockStatements": "https://rome.tools/docs/lint/rules/useBlockStatements",
     "lint/correctness/useSingleCaseStatement": "https://rome.tools/docs/lint/rules/useSingleCaseStatement",
-    "lint/correctness/useSingleVarDeclarator": "https://rome.tools/docs/lint/rules/useSingleVarDeclarator",
-    "lint/correctness/useValidTypeof": "https://rome.tools/docs/lint/rules/useValidTypeof",
     "lint/correctness/useWhile": "https://rome.tools/docs/lint/rules/useWhile",
     "lint/correctness/noNewSymbol": "https://rome.tools/docs/lint/rules/noNewSymbol",
     "lint/correctness/noUselessFragments": "https://rome.tools/docs/lint/rules/noUselessFragments",
     "lint/correctness/noUnusedVariables": "https://rome.tools/docs/lint/rules/noUnusedVariables",
     "lint/correctness/noUnreachable": "https://rome.tools/docs/lint/rules/noUnreachable",
     "lint/correctness/noRestrictedGlobals": "https://rome.tools/docs/lint/rules/noRestrictedGlobals",
-    "lint/correctness/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
     "lint/correctness/noUndeclaredVariables": "https://rome.tools/docs/lint/rules/noUndeclaredVariables",
+    "lint/correctness/useValidTypeof": "https://rome.tools/docs/lint/rules/useValidTypeof",
+    "lint/correctness/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
+    "lint/correctness/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
+    "lint/correctness/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
+    "lint/correctness/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
 
-    // style category
+    // style group
     "lint/style/noNegationElse": "https://rome.tools/docs/lint/rules/noNegationElse",
     "lint/style/noShoutyConstants": "https://rome.tools/docs/lint/rules/noShoutyConstants",
     "lint/style/useSelfClosingElements": "https://rome.tools/docs/lint/rules/useSelfClosingElements",
     "lint/style/useShorthandArrayType": "https://rome.tools/docs/lint/rules/useShorthandArrayType",
     "lint/style/useFragmentSyntax": "https://rome.tools/docs/lint/rules/useFragmentSyntax",
     "lint/style/useTemplate": "https://rome.tools/docs/lint/rules/useTemplate",
     "lint/style/useCamelCase": "https://rome.tools/docs/lint/rules/useCamelCase",
+    "lint/style/useSingleVarDeclarator": "https://rome.tools/docs/lint/rules/useSingleVarDeclarator",
+    "lint/style/useOptionalChain": "https://rome.tools/docs/lint/rules/useOptionalChain",
+    "lint/style/useBlockStatements": "https://rome.tools/docs/lint/rules/useBlockStatements",
+    "lint/style/noImplicitBoolean": "https://rome.tools/docs/lint/rules/noImplicitBoolean",
+    "lint/style/noUnusedTemplateLiteral": "https://rome.tools/docs/lint/rules/noUnusedTemplateLiteral",
 
     // complexity
     "lint/complexity/useSimplifiedLogicExpression": "https://rome.tools/docs/lint/rules/useSimplifiedLogicExpression",
     "lint/complexity/noExtraBooleanCast": "https://rome.tools/docs/lint/rules/noExtraBooleanCast",
 
-    // a11y category
+    // a11y group
     "lint/a11y/noAutofocus": "https://rome.tools/docs/lint/rules/noAutofocus",
     "lint/a11y/noPositiveTabindex": "https://rome.tools/docs/lint/rules/noPositiveTabindex",
     "lint/a11y/useKeyWithMouseEvents": "https://rome.tools/docs/lint/rules/useKeyWithMouseEvents",
@@ -65,21 +68,20 @@ define_dategories! {
     "lint/a11y/useValidAnchor": "https://rome.tools/docs/lint/rules/useValidAnchor",
     "lint/a11y/useKeyWithClickEvents": "https://rome.tools/docs/lint/rules/useKeyWithClickEvents",
     "lint/a11y/useButtonType": "https://rome.tools/docs/lint/rules/useButtonType",
-    // react
-    "lint/react/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
-    "lint/react/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
-    "lint/react/noVoidElementsWithChildren": "https://rome.tools/docs/lint/rules/noVoidElementsWithChildren",
-    "lint/react/noChildrenProp": "https://rome.tools/docs/lint/rules/noChildrenProp",
-    "lint/react/noRenderReturnValue": "https://rome.tools/docs/lint/rules/noRenderReturnValue",
-    "lint/react/noArrayIndexKey": "https://rome.tools/docs/lint/rules/noArrayIndexKey",
-
+    "lint/a11y/useAltText": "https://rome.tools/docs/lint/rules/useAltText",
+    // security
+    "lint/security/noDangerouslySetInnerHtml": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtml",
+    "lint/security/noDangerouslySetInnerHtmlWithChildren": "https://rome.tools/docs/lint/rules/noDangerouslySetInnerHtmlWithChildren",
+    "lint/security/noDebugger": "https://rome.tools/docs/lint/rules/noDebugger",
 
 
     // nursery
     "lint/nursery/useFlatMap": "https://rome.tools/docs/lint/rules/useFlatMap",
     "lint/nursery/noConstAssign": "https://rome.tools/docs/lint/rules/noConstAssign",
     "lint/nursery/noExplicitAny": "https://rome.tools/docs/lint/rules/noExplicitAny",
     "lint/nursery/useValidForDirection": "https://rome.tools/docs/lint/rules/useValidForDirection",
+    "lint/nursery/noInvalidConstructorSuper": "https://rome.tools/docs/lint/rules/noInvalidConstructorSuper",
+    "lint/nursery/useExhaustiveDependencies": "https://rome.tools/docs/lint/rules/useExhaustiveDependencies",
     ;
 
     // General categories

diff --git a/crates/rome_js_analyze/src/analyzers.rs b/crates/rome_js_analyze/src/analyzers.rs
diff --git a/crates/rome_js_analyze/src/analyzers/a11y.rs b/crates/rome_js_analyze/src/analyzers/a11y.rs
diff --git a/crates/rome_js_analyze/src/analyzers/a11y/no_auto_focus.rs b/crates/rome_js_analyze/src/analyzers/a11y/no_auto_focus.rs
@@ -51,7 +51,7 @@ declare_rule! {
     pub(crate) NoAutoFocus {
         version: "10.0.0",
         name: "noAutofocus",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/...yze/src/analyzers/nursery/use_alt_text.rs → ...nalyze/src/analyzers/a11y/use_alt_text.rs b/...yze/src/analyzers/nursery/use_alt_text.rs → ...nalyze/src/analyzers/a11y/use_alt_text.rs
@@ -42,7 +42,7 @@ declare_rule! {
     pub(crate) UseAltText {
         version: "10.0.0",
         name: "useAltText",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_anchor_content.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_anchor_content.rs
@@ -59,7 +59,7 @@ declare_rule! {
     pub(crate) UseAnchorContent {
         version: "10.0.0",
         name: "useAnchorContent",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_blank_target.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_blank_target.rs
@@ -52,7 +52,7 @@ declare_rule! {
     pub(crate) UseBlankTarget {
         version: "10.0.0",
         name: "useBlankTarget",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_key_with_click_events.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_key_with_click_events.rs
@@ -47,7 +47,7 @@ declare_rule! {
     pub(crate) UseKeyWithClickEvents {
         version: "10.0.0",
         name: "useKeyWithClickEvents",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_key_with_mouse_events.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_key_with_mouse_events.rs
@@ -45,7 +45,7 @@ declare_rule! {
     pub(crate) UseKeyWithMouseEvents {
         version: "10.0.0",
         name: "useKeyWithMouseEvents",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs
@@ -77,7 +77,7 @@ declare_rule! {
     pub(crate) UseValidAnchor {
         version: "10.0.0",
         name: "useValidAnchor",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/correctness.rs b/crates/rome_js_analyze/src/analyzers/correctness.rs
diff --git a/crates/rome_js_analyze/src/analyzers/correctness/no_new_symbol.rs b/crates/rome_js_analyze/src/analyzers/correctness/no_new_symbol.rs
@@ -29,7 +29,7 @@ declare_rule! {
     pub(crate) NoNewSymbol {
         version: "0.10.0",
         name: "noNewSymbol",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/correctness/no_unnecessary_continue.rs b/crates/rome_js_analyze/src/analyzers/correctness/no_unnecessary_continue.rs
@@ -7,7 +7,7 @@ use rome_rowan::{AstNode, BatchMutationExt};
 use crate::{utils, JsRuleAction};
 
 declare_rule! {
-    /// Avoid using unnecessary `ContinueStatement`.
+    /// Avoid using unnecessary `continue`.
     ///
     /// ## Examples
     ///

diff --git a/crates/rome_js_analyze/src/analyzers/correctness/no_unreachable.rs b/crates/rome_js_analyze/src/analyzers/correctness/no_unreachable.rs
@@ -47,7 +47,7 @@ declare_rule! {
     pub(crate) NoUnreachable {
         version: "0.7.0",
         name: "noUnreachable",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs
diff --git a/crates/rome_js_analyze/src/analyzers/security.rs b/crates/rome_js_analyze/src/analyzers/security.rs
diff --git a/.../src/analyzers/correctness/no_debugger.rs → ...yze/src/analyzers/security/no_debugger.rs b/.../src/analyzers/correctness/no_debugger.rs → ...yze/src/analyzers/security/no_debugger.rs
diff --git a/crates/rome_js_analyze/src/analyzers/style.rs b/crates/rome_js_analyze/src/analyzers/style.rs
diff --git a/...lyzers/correctness/no_implicit_boolean.rs → ...rc/analyzers/style/no_implicit_boolean.rs b/...lyzers/correctness/no_implicit_boolean.rs → ...rc/analyzers/style/no_implicit_boolean.rs
diff --git a/...correctness/no_unused_template_literal.rs → ...yzers/style/no_unused_template_literal.rs b/...correctness/no_unused_template_literal.rs → ...yzers/style/no_unused_template_literal.rs
diff --git a/...yzers/correctness/use_block_statements.rs → ...c/analyzers/style/use_block_statements.rs b/...yzers/correctness/use_block_statements.rs → ...c/analyzers/style/use_block_statements.rs
diff --git a/...alyzers/correctness/use_optional_chain.rs → ...src/analyzers/style/use_optional_chain.rs b/...alyzers/correctness/use_optional_chain.rs → ...src/analyzers/style/use_optional_chain.rs
@@ -73,7 +73,7 @@ declare_rule! {
     pub(crate) UseOptionalChain {
         version: "0.10.0",
         name: "useOptionalChain",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/.../correctness/use_single_var_declarator.rs → ...lyzers/style/use_single_var_declarator.rs b/.../correctness/use_single_var_declarator.rs → ...lyzers/style/use_single_var_declarator.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers.rs b/crates/rome_js_analyze/src/semantic_analyzers.rs
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/a11y/no_positive_tabindex.rs b/crates/rome_js_analyze/src/semantic_analyzers/a11y/no_positive_tabindex.rs
@@ -47,7 +47,7 @@ declare_rule! {
     pub(crate) NoPositiveTabindex {
         version: "10.0.0",
         name: "noPositiveTabindex",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/semantic_analyzers/a11y/use_button_type.rs b/crates/rome_js_analyze/src/semantic_analyzers/a11y/use_button_type.rs
@@ -38,7 +38,7 @@ declare_rule! {
     pub(crate) UseButtonType {
         version: "0.10.0",
         name: "useButtonType",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs b/crates/rome_js_analyze/src/semantic_analyzers/correctness.rs
diff --git a/...tic_analyzers/react/no_array_index_key.rs → ...alyzers/correctness/no_array_index_key.rs b/...tic_analyzers/react/no_array_index_key.rs → ...alyzers/correctness/no_array_index_key.rs
@@ -41,7 +41,7 @@ declare_rule! {
     pub(crate) NoArrayIndexKey {
         version: "0.10.0",
         name: "noArrayIndexKey",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/...antic_analyzers/react/no_children_prop.rs → ...analyzers/correctness/no_children_prop.rs b/...antic_analyzers/react/no_children_prop.rs → ...analyzers/correctness/no_children_prop.rs
@@ -25,7 +25,7 @@ declare_rule! {
     pub(crate) NoChildrenProp {
         version: "0.10.0",
         name: "noChildrenProp",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/...analyzers/react/no_render_return_value.rs → ...ers/correctness/no_render_return_value.rs b/...analyzers/react/no_render_return_value.rs → ...ers/correctness/no_render_return_value.rs
@@ -36,7 +36,7 @@ declare_rule! {
     pub(crate) NoRenderReturnValue {
         version: "0.10.0",
         name: "noRenderReturnValue",
-        recommended: false,
+        recommended: true,
     }
 }
 

diff --git a/...s/react/no_void_elements_with_children.rs → ...ectness/no_void_elements_with_children.rs b/...s/react/no_void_elements_with_children.rs → ...ectness/no_void_elements_with_children.rs
@@ -33,7 +33,7 @@ declare_rule! {
     pub(crate) NoVoidElementsWithChildren {
         version: "0.10.0",
         name: "noVoidElementsWithChildren",
-        recommended: false,
+        recommended: true,
     }
 }