This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(syntax): Remove quotes from tokens in JsSyntaxKind::to_string
#2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
💥 Failed to Panic (1):ts/babel
ts/microsoft
|
`JsSyntaxKind::to_string` should return the token's string representation without any additional quotes. Quoting should happen at the call side if necessary. This fixes some double-quoting of parentheses inside of parser diagnostic messages for different parentheses.
MichaReiser
force-pushed
the
fix/kind-to-string-escape
branch
from
51799e7 to
4efdfe1
Compare
Deploying with
|
| Latest commit: |
4efdfe1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7268f4b6.tools-8rn.pages.dev |
|
@xunilrj why is it that there's always one symbol test that changes from panic to failed? |
leops
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JsSyntaxKind::to_stringshould return the token's string representation without any additional quotes.Quoting should happen at the call side if necessary.
This fixes some double-quoting of parentheses inside of parser diagnostic messages for different parentheses.
Needed for #2447
Test Plan
cargo test