This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): Group ID in fits function #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
cd9c033
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f982176f.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-group-id-in-fits.tools-8rn.pages.dev |
MichaReiser
force-pushed
the
fix/group-id-in-fits
branch
from
e4ad862 to
b1b3524
Compare
ematipico
approved these changes
Jun 20, 2022
ematipico
reviewed
Jun 20, 2022
Excellent idea. I added a printer unit test to make the test independent of any future JS formatter changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2589 introduced
GroupIds that add support to refer to a specific group when usingif_group_breaksandif_group_fits_on_line. However, the implementation doesn't yet respect thegroup_idwhen measuring if a group (or element) fits on a line.This PR ensures that the printer retrieves the id of the referenced group when measuring if the content of a group fits.
Test Plan
You can see now that the numbers-trailing-comma.js.snap now no longer exceeds the line. The issue was that printing the last element and the
,exceeded the print width.