Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor: Using default derive macro instead of manual implementation for Enum #3069

Merged
merged 3 commits into from
Aug 17, 2022
Merged

refactor: Using default derive macro instead of manual implementation for Enum #3069

merged 3 commits into from
Aug 17, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

Summary

  1. Part of ☂️ Tracking issues or potential improvement we could make after upgrades to the Rust toolchain #3054
  2. From Rust 1.62 it's now possible to derive the Default trait on enums, we could track down and remove the manual implementations for these
  3. See https://rust-lang.github.io/rfcs/3107-derive-default-enum.html

Test Plan

  1. The CI should pass.

@IWANABETHATGUY IWANABETHATGUY requested a review from a team August 16, 2022 15:47
@IWANABETHATGUY IWANABETHATGUY changed the title refactor: Using derive enum macro instead of manual implementation refactor: Using default derive macro instead of manual implementation for Enum Aug 16, 2022
@MichaReiser MichaReiser merged commit fa5cbb5 into rome:main Aug 17, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the refactor/enum-default branch August 17, 2022 13:37
IWANABETHATGUY added a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
@IWANABETHATGUY
refactor: Using default derive macro instead of manual implementation…
3359a47 
… for Enum (rome#3069)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xunilrj xunilrj xunilrj left review comments

@MichaReiser MichaReiser MichaReiser approved these changes

@leops leops Awaiting requested review from leops

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IWANABETHATGUY @xunilrj @MichaReiser