This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
docs(rome_diagnostics): add a contributor documentation file for diagnostics #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
reviewed
Oct 12, 2022
Co-authored-by: Emanuele Stoppa <[email protected]>
Here's some feedback after working with the new diagnostics:
|
@leops should we start merging this PR and then continue with other PRs? There haven't been updates recently |
Ah yes I wanted to add an additional section that show what a diagnostic looks like when it gets printed along with all the advice types, but we could merge this now and extend it later |
ematipico
approved these changes
Oct 19, 2022
leops
added
A-Diagnostic
Area: errors and diagnostics
A-Documentation
Area: documentation
labels
Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new file in
crates/rome_diagnostics/CONTRIBUTING.md
that serves as a documentation on how to write diagnostics, with both technical explanations and best practices to write good errors for the user.Test Plan
N/A