This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): Arrow with JSX Body #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1 task
|
It seems there are regressions in the test suite... |
This PR fixes two issues related to formatting arrow function expressions with an arrow body:
```javascript
function ArrowBodyIsJsxWithComment({ action }) {
return (action) => (
// eslint-disable-next-line react/no-array-index-key
<li />
);
}
```
Keep the opening `(` on the same line as the arrow for JSX Tag expressions with a leading comment.
```javascript
<div
onClick={() =>
doSomething({
foo: bar
})
}
/>;
```
Place the closing `}` of the arrow body on a new line if the arrow is inside a jsx attribute
## Tests
I added new snapshot tests
MichaReiser
force-pushed
the
fix/jsx-arrow
branch
from
9bcf5d4 to
d6de41b
Compare
ematipico
approved these changes
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues related to formatting arrow function expressions with an arrow body:
Keep the opening
(on the same line as the arrow for JSX Tag expressions with a leading comment.Place the closing
}of the arrow body on a new line if the arrow is inside a jsx attributeFixes #3377
Tests
I added new snapshot tests