Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

docs(website): added checkbox to toggle linter in playground #3699

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

PatrM
Copy link
Contributor

@PatrM PatrM commented Nov 13, 2022

Summary

Fixes #3010

I added a checkbox in the Linter section.
image

  • The Linter / Diagnostics tab in Playground now displays the message Linter is currently disabled, in case the tab is open, but the checkbox unchecked
  • The nursery rules checkbox becomes disabled, but displays its previous value if linting is disabled

@PatrM PatrM requested a review from a team November 13, 2022 09:28
@netlify
Copy link

netlify bot commented Nov 13, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a0811b3
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637132f5e2e59d0009997615
😎 Deploy Preview https://deploy-preview-3699--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PatrM PatrM changed the title doc(website): added checkbox to toggle linter in playground docs(website): added checkbox to toggle linter in playground Nov 13, 2022
@sebmck
Copy link
Contributor

sebmck commented Nov 13, 2022

Thank you so much!

@sebmck sebmck merged commit 35a6555 into rome:main Nov 13, 2022
jeysal added a commit to jeysal/rometools that referenced this pull request Nov 14, 2022
* upstream/main: (45 commits)
  website(docs): set `color-scheme` on the root element (rome#3721)
  feat(rome_analyze): add a warning for unused suppression comments (rome#3718)
  feat(rome_js_analyze): Implement prefer-numeric-literals lint (rome#3558)
  feat(rome_js_formatter): jestEach template literals rome#3308 (rome#3582)
  doc(website): Add context about Romes philosophy (rome#3714)
  fix(rome_js_formatter): Single-line comment below a JSX prop triggers… (rome#3641)
  test(rome_js_formatter): update prettier tests (rome#3684)
  fix(rome_js_parser): improve await handling in non-async context (rome#3573)
  fix(rome_js_parser): improve yield parsing in non generator function (rome#3622)
  More playground polish
  Fix backgrounds
  Fix height
  Align docs.rome.tools with rome.tools
  Reenable compression
  Add missing width
  website(docs): More playground IDE features (rome#3711)
  fix(rome_js_formatter): new expression attribute (rome#3686)
  docs(website): added checkbox to toggle linter in playground (rome#3699)
  website(docs): More website tweaks (rome#3707)
  website(docs): Add default layout property (rome#3705)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tab in the playground to show lint diagnostics
3 participants