Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noSetterReturn #3783

Merged
merged 2 commits into from
Nov 23, 2022
Merged

feat(rome_js_analyze): noSetterReturn #3783

merged 2 commits into from
Nov 23, 2022

Conversation

Conaclos
Copy link
Contributor

Summary

This implements Deno Lint noSetterReturn.

Test Plan

Unit tests included.

@Conaclos Conaclos requested a review from a team November 17, 2022 21:34
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a7ba960
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637d55d5c8582700082f8bac

@Conaclos Conaclos changed the title feat(rome_js_analyze): noSetterReturn feat(rome_js_analyze): noSetterReturn Nov 19, 2022
@Conaclos Conaclos requested review from leops and removed request for xunilrj and ematipico November 19, 2022 11:18
@MichaReiser MichaReiser added A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Nov 21, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 21, 2022
@Conaclos
Copy link
Contributor Author

Conaclos commented Nov 22, 2022

@ematipico I rebased this branch on noConstructorReturn. This should allow merging noSetterReturn just after noConstructorReturn. I am not sure it is possible to process like this. Lets me know.

@MichaReiser MichaReiser merged commit 2146cf2 into rome:main Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter L-JavaScript Langauge: JavaScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants