fix(semantic_analyzers): style/noShoutyConstants does not recognize multiple uses of a constant.

crates/rome_js_analyze/src/semantic_analyzers/style/no_shouty_constants.rs

@@ -5,8 +5,8 @@ use rome_diagnostics::Applicability;
 use rome_js_semantic::{AllReferencesExtensions, Reference};
 use rome_js_syntax::{
     JsAnyExpression, JsAnyLiteralExpression, JsIdentifierBinding, JsIdentifierExpression,
-    JsStringLiteralExpression, JsVariableDeclaration, JsVariableDeclarator,
-    JsVariableDeclaratorList,
+    JsStringLiteralExpression, JsVariableDeclaration, JsVariableDeclarationClause,
+    JsVariableDeclarator, JsVariableDeclaratorList,
 };
 use rome_rowan::{AstNode, BatchMutationExt, SyntaxNodeCast};
 
@@ -101,6 +101,14 @@ impl Rule for NoShoutyConstants {
                     return None;
                 }
 
+                if binding.all_references(ctx.model()).all(|r| {
+                    r.node()
+                        .ancestors()
+                        .any(|n| JsVariableDeclarationClause::can_cast(n.kind()))
+                }) {
+                    return None;
+                }
+
                 return Some(State {
                     literal,
                     references: binding.all_references(ctx.model()).collect(),

crates/rome_js_analyze/tests/specs/style/noShoutyConstants.js

@@ -6,6 +6,13 @@ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
 console.log(FOO, FOO4);
 
 let foo = "foo";
+const B = "B";
+export default B;
+export const A = "A";
 
-const A = "A";
-export default A;
+const BAR = "BAR";
+const BAR1 = "BAR1";
+console.log(BAR1);
+export const bar = {
+	foo: Bar,
+};

crates/rome_js_analyze/tests/specs/style/noShoutyConstants.js.snap

@@ -1,5 +1,6 @@
 ---
 source: crates/rome_js_analyze/tests/spec_tests.rs
+assertion_line: 73
 expression: noShoutyConstants.js
 ---
 # Input
@@ -12,9 +13,17 @@ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
 console.log(FOO, FOO4);
 
 let foo = "foo";
+const B = "B";
+export default B;
+export const A = "A";
+
+const BAR = "BAR";
+const BAR1 = "BAR1";
+console.log(BAR1);
+export const bar = {
+	foo: Bar,
+};
 
-const A = "A";
-export default A;
 ```
 
 # Diagnostics
@@ -144,4 +153,41 @@ noShoutyConstants.js:4:34 lint/style/noShoutyConstants  FIXABLE  ━━━━━
 
 ```
 
+```
+noShoutyConstants.js:14:7 lint/style/noShoutyConstants  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Redundant constant declaration.
+
+    13 │ const BAR = "BAR";
+  > 14 │ const BAR1 = "BAR1";
+       │       ^^^^^^^^^^^^^
+    15 │ console.log(BAR1);
+    16 │ export const bar = {
+
+  i Used here.
+
+    13 │ const BAR = "BAR";
+    14 │ const BAR1 = "BAR1";
+  > 15 │ console.log(BAR1);
+       │             ^^^^
+    16 │ export const bar = {
+    17 │ 	foo: Bar,
+
+  i You should avoid declaring constants with a string that's the same
+        value as the variable name. It introduces a level of unnecessary
+        indirection when it's only two additional characters to inline.
+
+  i Suggested fix: Use the constant value directly
+
+    12 12 │   
+    13 13 │   const BAR = "BAR";
+    14    │ - const·BAR1·=·"BAR1";
+    15    │ - console.log(BAR1);
+       14 │ + console.log("BAR1");
+    16 15 │   export const bar = {
+    17 16 │   	foo: Bar,
+
+
+```
+