Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_cli): don't add newline when formatting from stdin #4263

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

ematipico
Copy link
Contributor

Summary

Fixes #4197

Test Plan

Tested locally

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 7d33b52
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6405b1b23f18100008cf44f9
😎 Deploy Preview https://deploy-preview-4263--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico added the A-CLI Area: CLI label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48647 48647 0
Passed 47582 47582 0
Failed 1065 1065 0
Panics 0 0 0
Coverage 97.81% 97.81% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6093 6093 0
Passed 1783 1783 0
Failed 4310 4310 0
Panics 0 0 0
Coverage 29.26% 29.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 568 568 0
Failed 71 71 0
Panics 0 0 0
Coverage 88.89% 88.89% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16740 16740 0
Passed 12815 12815 0
Failed 3925 3925 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

@ematipico ematipico changed the title fix(rome_cli): don't add newline when formatting from std fix(rome_cli): don't add newline when formatting from stdin Mar 6, 2023
@ematipico ematipico merged commit 9f50257 into main Mar 6, 2023
@ematipico ematipico deleted the fix/console-trait-println branch March 6, 2023 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 rome format appends an extra newline when formatting from stdin to stdout
1 participant