This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noNamespace #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Conaclos
suggested changes
Mar 9, 2023
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
ematipico
suggested changes
Mar 9, 2023
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_namespace.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Victorien ELVINGER <[email protected]>
Conaclos
suggested changes
Mar 10, 2023
Conaclos
suggested changes
Mar 10, 2023
Co-authored-by: Victorien ELVINGER <[email protected]>
Conaclos
approved these changes
Mar 10, 2023
ematipico
approved these changes
Mar 10, 2023
|
@noftaly Thanks for your contribution! :) |
|
No problem! Thanks for the guidance and the well-written contributing guide! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the
noNamespacerule, to disallow the use of TypeScript's namespaces, in favour of ES Modules. akin http://typescript-eslint.io/rules/no-namespace/Fixes #4274
Test Plan
Documentation
As this is my first contribution to Rome, don't refrain from suggesting how it could be improved or what I should maybe do differently. I'm happy to discuss! :)