fix(rome_js_analyze): noRedeclaration declaration merging

[Conaclos]

Summary

Fixes #4287.

While I was fixing the issue, I realized that noDuplicateParameters and noRedeclaration have some intersections. We could merge these two rules in another PR?

EDIT: this PR also allows duplicate parameters. To prevent duplicate parameters use noSuplicateParameters instead.

Test Plan

Extended.

Documentation

Updated.

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	9b5131e
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/6412fa0bd548c5000820b678

[ematipico]

While I was fixing the issue, I realized that noDuplicateParameters and noRedeclaration have some intersections. We could merge these two rules in another PR?

The two rules have different scopes. noRedeclaration should catch cases like

let a;
let a;

Which causes a different error (runtime).

[Conaclos]

Which causes a different error (runtime).

Good point.
It is a bit more complex than it. The rule also forbids var redeclaration that are not a runtime error.
However, it is a special case.

The rule must thus be reworked to avoid to report duplicate parameters.

[Conaclos]

Which causes a different error (runtime).

Note: the rule also reports function redeclarations which are allowed in JavaScript.