This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4300
This PR introduces a new method in our workspace called
organize_imports
, this method is needed because, while the import sorting is part of the analyzer, it's not something we can mix with the linter. Important sorting, in this PR, becomes an independent check like formatting and linting.This required the creation of few new diagnostics.
I split the traversal module in smaller files, because it was becoming quite long.
FYI
Plus, this PR furtherly updates the LSP to consider the configuration and apply the
organizeImports
action only when it's supported by the workspace.Test Plan
I added new test cases. Manually tested that the LSP doesn't sort the imports if the feature is disabled via configuration.
Documentation