This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix: keep quotes in the case of keys that are octal literals #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
denbezrukov
reviewed
Mar 18, 2023
| @@ -247,6 +247,11 @@ impl<'token> LiteralStringNormaliser<'token> { | |||
| let mut has_seen_number = false; | |||
| text_to_check.chars().enumerate().all(|(index, c)| { | |||
| if index == 0 && c.is_numeric() { | |||
There was a problem hiding this comment.
I'm wondering if we have to use here is_ascii_digit What do you think?
Because is_numeric https://doc.rust-lang.org/std/primitive.char.html#method.is_numeric
assert!('৬'.is_numeric());
assert!('¾'.is_numeric());
assert!('①'.is_numeric());
I'm not sure if it's valid.
Could you test please? 🙏
There was a problem hiding this comment.
@denbezrukov do you have an use case/test case that we can use ?
There was a problem hiding this comment.
There was a problem hiding this comment.
I use is_ascii_digit and update test 👍
ematipico
approved these changes
Mar 19, 2023
denbezrukov
reviewed
Mar 19, 2023
|
|
||
| const x = { | ||
| ¾¾¾¾: "test1", | ||
| ①: "test2", |
There was a problem hiding this comment.
I guess that correct one is
const x = {
"¾¾¾¾": "test1",
"①": "test2",
};
There was a problem hiding this comment.
I tried to fix in 10b568f.
denbezrukov
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4284
Test Plan
I updated tests and confirmed the issue was fixed.
Documentation