-
Notifications
You must be signed in to change notification settings - Fork 657
feat(rome_js_analyzer): noConsoleLog
rule
#4357
Conversation
3690a31
to
4786ef8
Compare
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4786ef8
to
8088472
Compare
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be nice to add other valid codes such as:
console.info("info")
console.warn("warn")
console.error("error")
console.assert(true)
8088472
to
13af9fd
Compare
Where precisely? In the test suite or the documentation? EDIT: I have done both |
13af9fd
to
3f2fc0c
Compare
Yesssss you guys are absolute machines |
I'm curious (but I don't need it): Is there a reason that things like |
Uncaught case from my side :) Although all the rules don't take that into consideration, probably because most of the users (myself in primis) don't use it, so it was missed. |
I don't use it either, but it's an easy workaround to the rule. |
Summary
Implements the rule
noConsoleLog
.Closes #4223
This rule prevents the usage of
console.log
, while all the other functions fromconsole
are allowed.Test Plan
Added tests
Changelog
Documentation