fix(rome_cli): Use lines() separator for os independent git ignore pa…

[m1212e]

Summary

This PR fixes parsing issues with the .gitignore files on windows. Currently the lines of the read .gitignore are separated by \n which causes the parsing to break with \r\n. The lines() method does fix this behavior.

Changelog

• The PR requires a changelog line

Documentation

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	d6bc77c
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/6492c22c9ab15c00081ee980
😎 Deploy Preview	https://deploy-preview-4558--docs-rometools.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[ematipico]

Thank you for your contribution! I'd ask you the following changes:

• restore the PR template and fill it
• add a changelog line, as explained in the contribution guide
• add a new test case with a gitignore file that has CRLF

[ematipico]

Closes #4556

[m1212e]

Sure, I hope this is correct? Tbh this is the first time that I pr a repo with changelog requirements, please excuse any mistakes :D
I don't really understand how the tests work and where to add it, would that be in https://github.com/m1212e/tools/blob/a3de5f50d348359e9c2e27a7046bf912de6d7a73/crates/rome_cli/tests/commands/check.rs#L1793 ? Did I overlook docs on how the tests are structured?

[ematipico]

Sure, I hope this is correct? Tbh this is the first time that I pr a repo with changelog requirements, please excuse any mistakes :D

Don't you worry, we will guide you to every step to make an awesome contribution!

I don't really understand how the tests work and where to add it, would that be in m1212e/tools@a3de5f5/crates/rome_cli/tests/commands/check.rs#L1793 ? Did I overlook docs on how the tests are structured?

Yes exactly! You can copy-paste that test, change the name of the function and the name of the snapshot - it's at the end of the function. We usually keep function name and name of the function the same. Then change git_ignore string to have \r\n inside its content.

[m1212e]

Ok, I had to read about snapshot tests but thats actually pretty cool, I hope this is correct?

[ematipico]

Fantastic, thank you for your contribution! ❤️