This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_analyze): add new TypeSCript globals #4644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4643
This PR updates my first contribution to Rome! :)
Actually the description of my first PR was really useful. I take the opportunity to improve the process:
I retrieved the types using the following command:
I extracted the current list of type with the following commands:
I also stored the concrete JavaScript values in a file named
js_types
.cat js_types * AggregateError Array ArrayBuffer BigInt BigInt64Array BigUint64Array Boolean DataView Date Error EvalError FinalizationRegistry Float32Array Float64Array Function Int16Array Int32Array Int8Array JSON Map Math Number Object Promise RangeError ReferenceError RegExp Set SharedArrayBuffer String SuppressedError Symbol SyntaxError TypeError URIError Uint16Array Uint32Array Uint8Array Uint8ClampedArray WeakMap WeakRef WeakSet
I removed from
all_types
, the values ofjs_types
:And I extracted the new ts types:
I updated the Rome list by adding the new types.
Test Plan