This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_service): better messaging for rule options #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Linter
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
|
@unvalley I added a new |
ematipico
commented
Jul 6, 2023
Comment on lines
-25
to
-28
| - enumMemberCase | ||
| - hooks | ||
| - maxAllowedComplexity | ||
| - strictCase |
There was a problem hiding this comment.
@Conaclos what do you think? I'd say now the messages are better
Conaclos
approved these changes
Jul 6, 2023
Comment on lines
-25
to
-28
| - enumMemberCase | ||
| - hooks | ||
| - maxAllowedComplexity | ||
| - strictCase |
unvalley
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the way we deserialize the options of the lint rules.
I wasn't delighted with the diagnostic messages, there were very unclear and we were showing suggestions that didn't belong to the rule we were scanning.
I created ad-hoc functions to pass down the rule name and use it to emit correct diagnostics. This involves a bit more code, but it gives the user a better message.
Test Plan
Added new test cases and updated the current ones