This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
feat(rome_js_analyze): useIsArray #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
github-actions
bot
added
A-Linter
Area: linter
A-Project
Area: project configuration and loading
A-Diagnostic
Area: errors and diagnostics
labels
Jul 14, 2023
github-actions
bot
added
A-Core
Area: core
A-Formatter
Area: formatter
A-Parser
Area: parser
A-Tooling
Area: our own build, development, and release tooling
labels
Jul 15, 2023
@ematipico Before adding doc tests for new public functions. I would like some review of these. I added several functions on |
I'm wondering if there is a performance difference between |
I think it is optimized by the compiler and should not be noticeable. |
!bench_analyzer |
Analyzer Benchmark Results
|
ematipico
reviewed
Jul 16, 2023
ematipico
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Core
Area: core
A-Diagnostic
Area: errors and diagnostics
A-Formatter
Area: formatter
A-Linter
Area: linter
A-Parser
Area: parser
A-Project
Area: project configuration and loading
A-Tooling
Area: our own build, development, and release tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement no-instanceof-array under the name
useIsArray
.Test Plan
Tests included.