This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_syntax): improve inner_string_text
#4731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the concistency of the code-base. It introduces several changes:
QuotedString
andStaticStringValue
in favor ofTokenText
andStaticValue
.This removes a bug in the implementation of
QuotedString
that was not reported yet.StaticValue
by replacingTemplateChunk
withString
andEmptyString
-0
and+0
has no sense because we only handle positive numbers...)${1}
" because this leads to erroneous string values (for instance${1n}
is converted to the string1n
instead of the string1
).There is more refactoring to do (maybe removing
StaticValue
in favor of an union of AST nodes). However, there are already many changes. This seems enough for this PIR.Test Plan
Updated and new doc-tests.