New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision-detection code is wrong #14

Closed

lurch opened this issue Dec 10, 2012 · 1 comment

lurch commented Dec 10, 2012

I think the code in https://github.com/quick2wire/quick2wire-python-api/blob/master/src/quick2wire/board_revision.py should be checking for:
in ['2','3']
rather than:
in ['1','2']

References:
http://www.raspberrypi.org/archives/1929
http://code.google.com/p/raspberry-gpio-python/source/browse/source/cpuinfo.c
http://www.andrewscheller.co.uk/adc_demo.py

romilly added a commit that referenced this issue


          fixed revision detection code - see issue #14

bfd4e6f

Owner

romilly commented Dec 10, 2012

You're right. Now corrected. Thanks.

romilly closed this as completed

lurch mentioned this issue

Revision-detection code is fragile #43

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment