Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p10k configure error message unless setopt multibyte is on #2397

Closed
phord opened this issue Jul 27, 2023 · 5 comments
Closed

p10k configure error message unless setopt multibyte is on #2397

phord opened this issue Jul 27, 2023 · 5 comments

Comments

@phord
Copy link

phord commented Jul 27, 2023

Why must I manually enable the multibyte option before running p10k configure?

If this really is necessary, maybe it should be mentioned in the README.

> p10k configure
[ERROR] p10k configure: multibyte option is not set

> setopt multibyte
> p10k configure

New config: ~/.p10k.zsh.
    :
@romkatv
Copy link
Owner

romkatv commented Jul 28, 2023

Why do you have multibyte disabled? What's your use case?

@romkatv
Copy link
Owner

romkatv commented Jul 29, 2023

I took a look at the code and was unable to figure out why the hard requirement for MULTIBYTE exists. I've replaced it with graceful degradation similar to what happens when you run p10k configure without a UTF-8 locale.

I'm still curious to know why you've disabled MULTIBYTE in your shell.

@phord
Copy link
Author

phord commented Jul 31, 2023

I don't know why it's disabled in my shell. I think it goes back to a bug in Gnome Terminal that was fixed 5 years ago.

It was annoying to get a fatal error message telling me about a specific cause but which then offered no advice for how to fix it.

@romkatv
Copy link
Owner

romkatv commented Jul 31, 2023

Thanks for the explanation.

How you fix it depends on your configs. In a nutshell, you need to find and delete the piece of code in your zsh startup files that disables multibyte.

@romkatv romkatv closed this as completed Jul 31, 2023
@phord
Copy link
Author

phord commented Jul 31, 2023

Yes, I did figure out how to fix it. I just felt like the error message could have been more helpful.

I did check my config history to see why I turned it off. But it was in my config before my dotfiles repo existed, so it goes back more than 10 years. Bit-rot, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants