Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ChromeDriver version selection #170

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

roniemartinez
Copy link
Owner

Resolves #169

@roniemartinez roniemartinez added enhancement New feature or request dependencies Pull requests that update a dependency file ci Continuous Integration labels Jun 4, 2022
@roniemartinez roniemartinez added this to the Alpha milestone Jun 4, 2022
@roniemartinez roniemartinez self-assigned this Jun 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #170 (f6acc76) into master (f3bac0c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   97.75%   97.69%   -0.07%     
==========================================
  Files          14       14              
  Lines        1156     1169      +13     
==========================================
+ Hits         1130     1142      +12     
- Misses         26       27       +1     
Impacted Files Coverage Δ
dude/optional/selenium_scraper.py 100.00% <100.00%> (ø)
dude/optional/utils.py 100.00% <100.00%> (ø)
dude/playwright_scraper.py 81.20% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3bac0c...f6acc76. Read the comment docs.

@roniemartinez roniemartinez merged commit 0247c3b into master Jun 4, 2022
@roniemartinez roniemartinez deleted the chromedriver-version-selection branch June 4, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically get ChromeDriver latest release
2 participants