Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict field renaming to one occurrence #20

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Restrict field renaming to one occurrence #20

merged 2 commits into from
Jan 10, 2025

Conversation

colodenn
Copy link
Member

A customer on Discord highlighted an issue where the CLI suggested renaming a field from A to B and A to C within the same migration creation process, which is illogical. This PR addresses the issue by ensuring that a field can only be renamed once per migration creation step.

@colodenn colodenn requested a review from leo January 10, 2025 09:40
@colodenn colodenn self-assigned this Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

Released an experimental package:

bun add @ronin/cli@corny-ron-1071-experimental-52

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/field.ts 100.00% <100.00%> (ø)
tests/fixtures/index.ts 100.00% <100.00%> (ø)

@colodenn colodenn marked this pull request as ready for review January 10, 2025 09:49
@colodenn colodenn merged commit 6fc11cd into main Jan 10, 2025
3 checks passed
@colodenn colodenn deleted the corny/ron-1071 branch January 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants