[consensus] set stake threshold override for msim tests (MystenLabs#1…

…7673)
ronny-mysten · May 12, 2024 · 7ac16a8 · 7ac16a8
1 parent dd97d3d
commit 7ac16a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/consensus/core/src/leader_schedule.rs b/consensus/core/src/leader_schedule.rs
@@ -264,8 +264,12 @@ impl LeaderSwapTable {
     pub(crate) fn new(
         context: Arc<Context>,
         reputation_scores: ReputationScores,
-        swap_stake_threshold: u64,
+        // Needed to prevent linter warning in simtests
+        #[allow(unused_variables)] swap_stake_threshold: u64,
     ) -> Self {
+        #[cfg(msim)]
+        let swap_stake_threshold = 33;
+
         assert!(
             (0..=33).contains(&swap_stake_threshold),
             "The swap_stake_threshold ({swap_stake_threshold}) should be in range [0 - 33], out of bounds parameter detected"

diff --git a/consensus/core/src/leader_scoring.rs b/consensus/core/src/leader_scoring.rs
@@ -66,7 +66,7 @@ impl<'a> ReputationScoreCalculator<'a> {
 
     pub(crate) fn calculate(&mut self) -> ReputationScores {
         let leaders = self.unscored_subdag.committed_leaders.clone();
-        for leader in leaders.into_iter() {
+        for leader in leaders {
             let leader_slot = Slot::from(leader);
             tracing::trace!("Calculating score for leader {leader_slot}");
             self.add_scores(