Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require Base64 and CSV #616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Explicitly require Base64 and CSV #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb35b34
Explicitly require base64 and csv
HashNotAdam Dec 26, 2024
c3b2a7a
Include Ruby 3.4 in the GitHub Actions workflow
HashNotAdam Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ jobs:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
- ruby-head
- jruby-9.3.3.0
- jruby-9.4.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such version

Copy link

@tagliala tagliala Feb 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be available now, 9.4.10.0 it has been merged and released a few days ago: ruby/setup-ruby/pull/697

Just discovered that there is also 9.4.11.0 ruby/setup-ruby#699

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- jruby-9.4.10.0
- jruby-9.4.9.0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seems v10 not released for ubuntu-24.04 yet.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In changelog file top, I guess something like:

##  Unreleased

### Changed/Added
- Added 'Base64' and 'CSV' as dependencies, both not bundled starting with Ruby 3.4 [604](https://github.com/roo-rb/roo/issues/604)

include:
- ruby: ruby-head
env:
Expand All @@ -33,4 +34,3 @@ jobs:
- run: bundle exec rake
env:
LONG_RUN: true

4 changes: 4 additions & 0 deletions roo.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = ">= 2.7.0"
end

if RUBY_VERSION >= '3.4.0'
spec.add_dependency 'base64', '~> 0.2'
spec.add_dependency 'csv', '~> 3'
end
spec.add_dependency 'nokogiri', '~> 1'
spec.add_dependency 'rubyzip', '>= 1.3.0', '< 3.0.0'

Expand Down
Loading