Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

first test on registering user #17

Merged
merged 16 commits into from
Apr 23, 2022
Merged

Conversation

Felexonyango
Copy link
Contributor

First test on user registration .

@Felexonyango
Copy link
Contributor Author

test one passed

@roopeshsn
Copy link
Owner

Hi! Thank you for contributing! Whether all test cases pass?

@Felexonyango
Copy link
Contributor Author

Felexonyango commented Apr 23, 2022 via email

Copy link
Owner

@roopeshsn roopeshsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like the files are not formatted properly

@roopeshsn
Copy link
Owner

Wait, I'll soon add the prettier configuration file so that the formatting will be made easy and the code styling looks the same for all the contributors who are involved in this project. Meanwhile, you continue writing test cases.

@Felexonyango
Copy link
Contributor Author

Alright , please add so that i can add on my end too... Thank you

@Felexonyango
Copy link
Contributor Author

solved kindly check at package-lock.json .I have updated new and i have completed user route kindly confirm before further proceedings

@Felexonyango
Copy link
Contributor Author

Here is screenshot of the tests
Screenshot from 2022-04-23 12-03-51

@Felexonyango
Copy link
Contributor Author

Screenshot from 2022-04-23 13-20-41

@roopeshsn
Copy link
Owner

Looks like there is a conflict. Undo the package-lock.json commit. I have updated the package-lock.json file. So use the git pull command.

This reverts commit c3b5faa.

reverting package lock json file
@roopeshsn roopeshsn merged commit 6809335 into roopeshsn:master Apr 23, 2022
@Felexonyango
Copy link
Contributor Author

Thank you for approving senior

@roopeshsn
Copy link
Owner

roopeshsn commented Apr 23, 2022

Good work @Felexonyango

Always use the git pull command before working from your side. I'll add a prettier config file after that I'll ask you to format your code. You run the specified command and commit once. I updated the package-lock.json file. Use the git pull from your side and confirm whether all works fine.

I would like you to be an active maintainer of this project. If you spot any bugs or performance-related issues please create an issue. So, that others can work on that. If you'd like to add any new feature please go ahead. Your contribution will highly benefit this project!

@Felexonyango
Copy link
Contributor Author

Thank you for granting me a role . sure I will

1 similar comment
@Felexonyango
Copy link
Contributor Author

Thank you for granting me a role . sure I will

@roopeshsn
Copy link
Owner

That's good to hear. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants