Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

spaces added between buttons #56

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

s-vamshi
Copy link
Contributor

@s-vamshi s-vamshi commented Oct 4, 2022

Updated UsersListScreen.js and ProductListScreen.js to add spaces between buttons

@roopeshsn
Copy link
Owner

I need to verify whether everything works fine. Could you add screenshots both in mobile and desktop view?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

Sure!

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

@roopeshsn
desktop view:
tem
mobile view
tem2

@roopeshsn
Copy link
Owner

In mobile view, the buttons are placed vertically. Could you do anything about that?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

I can make them to be horizontal without stacking downwards

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

tem3
Is this ok?

@roopeshsn
Copy link
Owner

Would like to know how you achieved this?

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

I have imported button group from react bootstrap and then used it to group buttons

Copy link
Owner

@roopeshsn roopeshsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I am not able to see the changes you've done to avoid vertical stacking!

@s-vamshi
Copy link
Contributor Author

s-vamshi commented Oct 4, 2022

@roopeshsn forgot to commit. Please check now

Copy link
Owner

@roopeshsn roopeshsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @s-vamshi

@roopeshsn roopeshsn merged commit 245c6a2 into roopeshsn:master Oct 4, 2022
@roopeshsn roopeshsn added the hacktoberfest-accepted Accepted PR for hactoberfest label Oct 4, 2022
@s-vamshi s-vamshi deleted the added-spaces-between-buttons branch October 5, 2022 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Accepted PR for hactoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants