This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Fixed bug while editing products in products list #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #86
The following is the state of products on /admin/productlist before updating any product:
After editting any of the products the state of productDetails becomes (note that there is no
product: {}
) :This causes a crash in line 47 of
frontend/src/screens/ProductEditScreen.js
, as product is not defined and we try to accessproduct.name
(when trying to edit any product for the second time).Hence, all I did was update the
productDetails
reducer when thePRODUCT_DETAILS_RESET
action is dispatched.P.S. The above screenshots were taken using Redux DevTools web extension.