This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Select option for category in create product screen #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roopeshsn
suggested changes
Oct 16, 2022
| }} | ||
| > | ||
| <option>--Select One--</option> | ||
| <option value="vegetables">Vegetables</option> |
There was a problem hiding this comment.
These fields should be dynamic. We have categories data stored in the DB. It will be great if you use those data to render categories.
There was a problem hiding this comment.
Sure will work on it.
|
@roopeshsn I have made changes. Can you please check? |
|
Could you share a screenshot? "--Select one--" is also an option right? What if the admin chooses "--Select One--" and proceeds to create a product? |
|
Have you formatted the code? |
yes i have made changes so when admin chooses "--Select one--" option this message will be shown |
Done |
roopeshsn
approved these changes
Oct 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #91.
Added pre - defined options to category field in create product screen and product edit screen.