Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.24.0 #1485

Merged
merged 28 commits into from
Jan 26, 2025
Merged

0.24.0 #1485

merged 28 commits into from
Jan 26, 2025

Conversation

kethinov
Copy link
Member

  • Breaking: Removed app.get('routes'), onReqAfterRoute, onReqBeforeRoute, onReqStart, and onStaticAssetsGenerated.
  • Breaking: Renamed app.httpServer to app.get('httpServer') and app.httpsServer to app.get('httpsServer').
  • Added new method onBeforeMiddleware.
  • Added start and stop method shorthands for startServer and stopServer respectively.
  • Refactored various things under the hood to improve code quality, performance, and reduce unnecessary dependencies.
  • Updated various dependencies.

kethinov and others added 28 commits September 13, 2024 12:21
… changes and internal generator are complete
- Breaking: Removed `app.get('routes')`, `onReqAfterRoute`, `onReqBeforeRoute`, `onReqStart`, and `onStaticAssetsGenerated`.
- Breaking: Renamed `app.httpServer` to `app.get('httpServer')` and `app.httpsServer` to `app.get('httpsServer')`.
- Added new method `onBeforeMiddleware`.
- Added `start` and `stop` method shorthands for `startServer` and `stopServer` respectively.
- Refactored various things under the hood to improve code quality, performance, and reduce unnecessary dependencies.
- Updated various dependencies.
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 88.16199% with 76 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (3ba6cab) to head (700772c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
roosevelt.js 95.48% 13 Missing ⚠️
lib/preprocessStaticPages.js 52.17% 11 Missing ⚠️
lib/jsBundler.js 50.00% 9 Missing ⚠️
lib/mapRoutes.js 81.08% 7 Missing ⚠️
lib/setExpressConfigs.js 89.79% 5 Missing ⚠️
lib/tools/fsr.js 80.00% 5 Missing ⚠️
lib/tools/gitignoreScanner.js 50.00% 5 Missing ⚠️
lib/scripts/certsGenerator.js 55.55% 4 Missing ⚠️
lib/scripts/sessionSecretGenerator.js 20.00% 4 Missing ⚠️
lib/preprocessCss.js 93.47% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   85.07%   85.91%   +0.84%     
==========================================
  Files          26       25       -1     
  Lines        3664     3089     -575     
==========================================
- Hits         3117     2654     -463     
+ Misses        547      435     -112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kethinov kethinov merged commit 8081989 into rooseveltframework:main Jan 26, 2025
11 checks passed
@kethinov kethinov deleted the refactor branch January 26, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants