Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cling depends on exact macOS SDK headers #7021

Closed
Axel-Naumann opened this issue Jan 12, 2021 · 2 comments · Fixed by #7625
Closed

cling depends on exact macOS SDK headers #7021

Axel-Naumann opened this issue Jan 12, 2021 · 2 comments · Fixed by #7625
Assignees
@vgvassilev
Labels
affects:master affects:6.22 bug in:Cling priority:high
Milestone
6.24/00

Comments

@Axel-Naumann
Copy link
Member

Describe the bug

See e.g. https://root-forum.cern.ch/t/homebrew-and-latest-macos-sdk/43049:

warning: no such sysroot directory: '/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk'

despite 11.1 being there

Expected behavior

Picks up 11.1 SDK.

Possibly use generic MacOSX.sdk directory instead.

To Reproduce

Download binaries built with 11.0 SDK while you have a newer Xcode / cmd line tools.
@Axel-Naumann Axel-Naumann self-assigned this Jan 12, 2021
@Axel-Naumann
Copy link
Member Author

https://root-forum.cern.ch/t/binary-installation-of-root-with-macos-11-1/43359/9

@Axel-Naumann Axel-Naumann added this to the 6.24/00 milestone Mar 5, 2021
@eguiraud
Copy link
Member

https://root-forum.cern.ch/t/segmentation-violation-on-big-sur-11-2-3/43950

vgvassilev added a commit to vgvassilev/root that referenced this issue Mar 19, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
ecd04d9 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project#7021.
@vgvassilev vgvassilev mentioned this issue Mar 19, 2021
Merged
vgvassilev added a commit to vgvassilev/root that referenced this issue Mar 21, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
d54b604 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project#7021.
vgvassilev added a commit that referenced this issue Mar 21, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
9ae2943 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve #7021.
vgvassilev added a commit to vgvassilev/root that referenced this issue Mar 21, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
13cb6d8 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project#7021.
@vgvassilev vgvassilev mentioned this issue Mar 21, 2021
Merged
vgvassilev added a commit to vgvassilev/root that referenced this issue Mar 21, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
d4523d8 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project#7021.
@vgvassilev vgvassilev mentioned this issue Mar 21, 2021
Merged
FonsRademakers pushed a commit to root-project/cling that referenced this issue Mar 21, 2021
@vgvassilev
Do not bind cling's sysroot to a particular version of osx sdk.
a89bbcb 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project/root#7021.
vgvassilev added a commit that referenced this issue Mar 22, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
5401d8f 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve #7021.
vgvassilev added a commit that referenced this issue Mar 22, 2021
@vgvassilev
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
66e8a63 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve #7021.
nicknagi pushed a commit to nicknagi/root that referenced this issue Mar 30, 2021
@vgvassilev @nicknagi
[cmake] Do not bind cling's sysroot to a particular version of osx sdk.
4fd0a56 
The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build
against. However, this means that binary releases become sensitive to minor sdk
upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is
relatively resilient to such changes.

This patch introduces a workaround to address this issue -- it uses the fact
that the current sdk's parent directory has a symlink MacOSX.sdk which points
to the current sdk.

This should resolve root-project#7021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgvassilev vgvassilev

Labels
affects:master affects:6.22 bug in:Cling priority:high
Projects
None yet
Milestone
6.24/00
Development

Successfully merging a pull request may close this issue.

[cmake] Do not bind cling's sysroot to a particular version of osx sdk. vgvassilev/root
3 participants
@Axel-Naumann @vgvassilev @eguiraud