Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add short version of help, as in quit #10055

Merged
merged 2 commits into from
Mar 15, 2022
Merged

add short version of help, as in quit #10055

merged 2 commits into from
Mar 15, 2022

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

Makes the short version of .help more visible (.?)

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ferdymercury ferdymercury requested a review from couet as a code owner March 5, 2022 22:01
This was referenced Mar 5, 2022
Closed
Closed
@ferdymercury
Copy link
Contributor Author

Maybe it's worth to mention? in the list that

  • .qqqqq for quitting if its hanging
  • CTRL+D also works as a way to exit
  • CTRL+C can interrupt
  • CTRL+Z stops

@couet
Copy link
Member

couet commented Mar 7, 2022

I see you updated the old user's guide changing documentation/users-guide/Cling.md . The this guide is not supposed to be updated. It is frozen. You should changed the "Manual" on the web of the reference guide (doxygen).

@ferdymercury
Copy link
Contributor Author

Thanks for the feedback. Reverted now.

This was referenced Mar 7, 2022
Merged
Closed
@jalopezg-git jalopezg-git self-requested a review March 7, 2022 19:31
jalopezg-git
jalopezg-git suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@jalopezg-git jalopezg-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @ferdymercury! :-) We need some changes though!

core/base/src/TApplication.cxx Outdated Show resolved Hide resolved
interpreter/cling/lib/MetaProcessor/MetaSema.cpp Outdated Show resolved Hide resolved
interpreter/cling/lib/MetaProcessor/MetaSema.cpp Outdated Show resolved Hide resolved
jalopezg-git
jalopezg-git suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@jalopezg-git jalopezg-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny changes required; but we are close! We would also need to squash the commits before merging. :-)

interpreter/cling/lib/MetaProcessor/MetaSema.cpp Outdated Show resolved Hide resolved
jalopezg-git
jalopezg-git reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@jalopezg-git jalopezg-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, LGTM! But the PR contains 22 commits for these relatively small changes. Could you run $ git rebase --interactive master and reorder commits, marking some of them as squash / fixup as appropriate before we can merge?

(EDIT: if you mess up during rebase, you can do $ git rebase --abort)

@ferdymercury
MetaSema: add short version of help, as in quit
3b79d18 
Primer: join help and ?, mention .quit and .exit
TRint: mention .?
TApplication: mention .? and CINT 2 Cling
@ferdymercury
clarify class name with ROOT7
a7a7036
@ferdymercury
Copy link
Contributor Author

Rebased.

@jalopezg-git
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/soversion.
See console output.

jalopezg-git
jalopezg-git approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@jalopezg-git jalopezg-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@couet
Copy link
Member

couet commented Mar 14, 2022

I see you also modified the primer. This guide as now 3 version. The one in the ROOT repo, the one on the web site and the Jupyter Notebook one which has its own repo. I think the idea will be to keep only one ie the Jupyter NB one.

This was referenced Mar 15, 2022
Merged
Merged
@ferdymercury
Copy link
Contributor Author

the one on the web site and the Jupyter Notebook one which has its own repo.

I just ported the changes also to those two other versions.

@couet couet merged commit 2e8f638 into root-project:master Mar 15, 2022
@ferdymercury ferdymercury deleted the patch-2 branch March 15, 2022 10:24
Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this pull request Apr 6, 2022
@ferdymercury
add short version of help, as in quit (root-project#10055)
06c6bf5 
* MetaSema: add short version of help, as in quit
Primer: join help and ?, mention .quit and .exit
TRint: mention .?
TApplication: mention .? and CINT 2 Cling

* clarify class name with ROOT7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalopezg-git jalopezg-git jalopezg-git approved these changes

@couet couet couet approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@Axel-Naumann Axel-Naumann

Labels
improvement in:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ferdymercury @phsft-bot @couet @jalopezg-git @Axel-Naumann