Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textinput] kCmdUndo: prevent accessing empty vector #10181

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[textinput] kCmdUndo: prevent accessing empty vector #10181

merged 1 commit into from
Mar 21, 2022

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

segmentation violation due to empty vector access

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #10180

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ferdymercury ferdymercury changed the title prevent accessing empty vector [textinput] prevent accessing empty vector on undo buffer Mar 21, 2022
@jalopezg-git jalopezg-git changed the title [textinput] prevent accessing empty vector on undo buffer [textinput] kCmdUndo: prevent accessing empty vector Mar 21, 2022
jalopezg-git
jalopezg-git approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@jalopezg-git jalopezg-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks!

@jalopezg-git
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@jalopezg-git jalopezg-git merged commit e60c77c into root-project:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalopezg-git jalopezg-git jalopezg-git approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@jalopezg-git jalopezg-git

Labels
affects:master bug in:Core Libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[textinput] segmentation violation on Undo shortcut
3 participants
@ferdymercury @phsft-bot @jalopezg-git