[RF] Add methods to create owning RooFit proxies via std::unique_ptr
#12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files 13 suites 2d 18h 34m 49s ⏱️ Results for commit ab48862. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
try_memsafe_1
branch
2 times, most recently
from
c8101a6 to
088aa7b
Compare
guitargeek
force-pushed
the
try_memsafe_1
branch
from
088aa7b to
6bd64db
Compare
guitargeek
force-pushed
the
try_memsafe_1
branch
from
6bd64db to
644dda7
Compare
guitargeek
force-pushed
the
try_memsafe_1
branch
from
dba601f to
7b79c79
Compare
At the same time, deprecate the constructors with manual memory ownership.
guitargeek
force-pushed
the
try_memsafe_1
branch
from
7b79c79 to
ab48862
Compare
guitargeek
changed the title
std::unique_ptr
lmoneta
reviewed
Aug 12, 2024
lmoneta
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to create owning RooFit proxies via
std::unique_ptr.At the same time, deprecate the constructors with manual memory
ownership.