builtin_davix: Drop PATCH_COMMAND
#16802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build fix for FreeBSD is included already since DAVIX 0.8.6, so the PATCH_COMMAND is not needed (it was merged because the PR was older, opened in February, than the upgrade of the builtin in May). In fact the command breaks builtin_davix on Linux systems because `sed -i` is not portable between GNU sed and BSD sed. (Note that the same is true for the patch itself, see my comment in cern-fts/davix#113 (comment) .)
Test Results 17 files 17 suites 3d 6h 56m 0s ⏱️ Results for commit 7067264. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build fix for FreeBSD is included already since DAVIX 0.8.6, so the
PATCH_COMMANDis not needed (it was merged because the PR was older, opened in February, than the upgrade of the builtin in May). In fact the command breaks builtin_davix on Linux systems becausesed -iis not portable between GNU sed and BSD sed. (Note that the same is true for the patch itself, see my comment in cern-fts/davix#113 (comment).)