612 backports #3547
Merged
612 backports #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
Build failed on mac1014/cxx17. Errors:
|
|
Build failed on ROOT-fedora27/noimt. Errors:
Warnings:
|
|
Build failed on ROOT-fedora29/python3. Errors:
Warnings:
|
|
Build failed on ROOT-ubuntu16/rtcxxmod. Errors:
Warnings:
And 7 more |
|
Build failed on ROOT-performance-centos7-multicore/default. Errors:
|
|
Build failed on windows10/default. Warnings:
|
|
errors are pre-existing. |
…ect.
This prevent the inappropriate execution on a rule intent for
an inner object on the outer object('s memory space)
In a case where the top level branch is:
1 edm::Wrapper<std::vector<pat::CompositeCandidate, std::allocator<pat::CompositeCandidate> > >
which contains
2 16, obj, vector<pat::CompositeCandidate> simple base pat::PATObject<reco::CompositeCandidate>
3 360, overlapItems_, vector<edm::PtrVector<reco::Candidate> > simple base edm::PtrVectorBase
4 48, cachedItems_, atomic<vector<const void*>*> ***TRANSIENT-WITH-RULE**
The TStreamerInfo Action Sequence for (4) was being executed the obj branch/level
The bug was that GatherArtificialElements would drill through (3) eventhough
it was not split and it did so because it did not recognize there was a branch for
it because it added (errorneously) the name of the base class in the branch prefix.
Lock was moved deeper
I.e. insure we do not add or substract from the special offset value kMissing (which result in 'valid' offset in the 10,000 range leading to memory over-write or out-of-bounds reads)
unique_ptr can be nullptr too sometimes *and* anyway TStreamerInfo::Build does not make the same restriction. The mismatch lead to baffling error message like: Warning in <TStreamerInfo::BuildOld>: Cannot convert A::h from type: B to type: B, skip element This solves one of the problems seen in https://sft.its.cern.ch/jira/browse/ROOT-9702.
This addresses part of ROOT-9762
When a rule is associated to the top level node of split collection, we must not add the branch offset, since the rule is about the content of the collection
GetCollectionProxy during the setting of fCollProxy calls TBranchElement::GetInfoImp that in some cases sets fCollProxy and ends up recording it (sometimes) in the action sequence. When GetCollectionProxy sets it too (i.e. change it) there is now a disconnect between the branch and the action sequences that lead to the action sequence to used an unset collection proxy: Fatal in <TGenCollectionProxy>: Size> Logic error - no proxy object set. aborting
pcanal
force-pushed
the
612-backport-001
branch
from
cc8302e to
a473580
Compare
|
Starting build on |
|
Build failed on mac1014/cxx17. Errors:
|
|
Build failed on ROOT-performance-centos7-multicore/default. Errors:
|
|
Build failed on windows10/default. Warnings:
|
|
Build failed on ROOT-fedora27/noimt. Errors:
Warnings:
|
|
Build failed on ROOT-ubuntu16/rtcxxmod. Errors:
Warnings:
And 7 more |
|
Build failed on ROOT-fedora29/python3. Errors:
Warnings:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.