Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cling PR 284 #4616

Closed
wants to merge 12 commits into from
Closed

cling PR 284 #4616

wants to merge 12 commits into from

Conversation

Axel-Naumann
Copy link
Member

@SimeonEhrig @Axel-Naumann
Extend cling::Intpereter to incremental compile PTX code for CUDA dev…
32736ce 
…ices

- change CUDA to CUDAHost and add CUDADevice to the InvocationOptions
- in the PTX mode, some ASTTransformer will not be used, which are useful for the x86 mode
@SimeonEhrig @Axel-Naumann
Added DeviceKernelInliner ASTTransformer
a618909 
This ASTTransformer adds an inline attribute to any CUDA __device__ kernel
that does not have the attribute. Inlining solves a problem caused by
incremental compilation of PTX code. In a normal compiler, all definitions
of __global__ and __device__ kernels are in the same translation unit. In
the incremental compiler, each kernel has its own translation unit. In case
a __global__ kernel uses a __device__ function, this design caused an error.
Instead of generating the PTX code of the __device__ kernel in the same file
as the __global__ kernel, there is only an external declaration of the
__device__ function. However, normal PTX code does not support an external
declaration of functions.

The transformer only works if the target device is nvptx.
@SimeonEhrig @Axel-Naumann
Replaced incremental PTX compiler with a internal implementation
02ac5c8 
Replaced the old version of the PTX compiler which used external tools and llvm::ExecuteAndWait with an internal implementation. The new incremental PTX compiler uses a modified version of the cling::Interpreter instance. The instance can process the PTX built-ins and generates LLVM IR. The LLVM IR is be compiled to PTX via an additional NVPTX backend implemented in the IncrementalCUDADeviceCompiler.

The new implementation has many advantages:
- it's much faster than the old version
- less error-prone because the ASTPrinter and some unnecessary cling transformations are avoided
- reduction of problems in searching for external tools (can be very complicated on HPC systems)

The IncrementalCUDADeviceCompiler is moved from the cling::IncrementalParser to the cling::Interpreter, because the second interpreter needs the input without wrappers or transformations.
@SimeonEhrig @Axel-Naumann
Support for the define argument (-D) in the CUDA mode
c4c83ad
@SimeonEhrig @Axel-Naumann
Setting a new include path at runtime in the PTX compiler now works
6c8dd08
@SimeonEhrig @Axel-Naumann
Add in-memory fatbin generation
83e85c1 
- instead of using the NVIDIA tool fatbin, the fatbin is now generated directly in the cling
- clean up the IncrementalCUDADeviceCompiler class depending on the new fatbin implementation (e.g. remove findToolChain())
- last I/O-operation is required -> write the fatbin code to a file for the CodeGen
@SimeonEhrig @Axel-Naumann
Add NVPTX backend to CPT
f7a0043
@SimeonEhrig @Axel-Naumann
Add -include argument to cling ptx
542bf26
@SimeonEhrig @Axel-Naumann
Refactor public interface of cling::IncrementalCUDADeviceCompiler
7eaec86 
- it is more similar to the interface of cling::Interpreter
- replace function compileDeviceCode() with process()
- add declare() and parse() functions
- the functions have only the argument input, because the rest of the missing arguments (e.g. Transaction) requires modifications at the transaction system
- it also fixes a bug in the I/O system of the xeus-cling kernel
@SimeonEhrig @Axel-Naumann
Add functionality to SourceNormalization to detect cuda kernels
39897fa 
- a really weak solution, which should replaced by a generic solution
@SimeonEhrig @Axel-Naumann
Changes for Pull Request root-project#284
41df26b 
- add Author to CUDA test cases
- optimize DeviceKernelInliner
- improve some comments
- remove deprecated opt level variables
- change interface of IncrementalCUDADeviceCompiler::process() IncrementalCUDADeviceCompiler::declare()
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann mentioned this pull request Nov 5, 2019
Closed
5 tasks
@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

  • FAILED: /usr/bin/ccache /usr/bin/c++ -DCLING_VERSION="ROOT_0.7~dev" -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iinterpreter/llvm/src/tools/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/include -Iinterpreter/llvm/src/tools/cling/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -Wno-nested-anon-types -Wno-covered-switch-default -Wno-unused-local-typedef -fno-rtti -O3 -DNDEBUG -fno-exceptions -fno-rtti -std=c++11 -MD -MT interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -MF interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o.d -o interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -c /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:35: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:31: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:33: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:35: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetInfo’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope; did you mean ‘LLVMInitializeX86Target’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetMC’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope; did you mean ‘LLVMInitializeX86AsmPrinter’?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora27/noimt.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@SimeonEhrig @Axel-Naumann
Add buffer for CUDA fatbinary in CGCUDANV backend
fe12679 
- the buffer is needed to send the fatbinary code from the device JIT to the host JIT without file I/O
- the modification was needed because the backend usse the function llvm::MemoryBuffer::getFileOrSTDIN() which does not support a virtual file system
- behavior: If the buffer is valid, use the buffer. Otherwise load fatbinary code from file.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann
Copy link
Member Author

@SimeonEhrig you said (in root-project/cling#284 (comment) )

I have removed the part of the code that requires changes to the clang base.

Yet the errors above seem to come from a missing llvm patch. Could you clarify?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetInfo’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope; did you mean ‘LLVMInitializeX86Target’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetMC’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope; did you mean ‘LLVMInitializeX86AsmPrinter’?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Errors:

  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:35: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:31: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:33: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:35: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

  • FAILED: /usr/bin/ccache /usr/bin/c++ -DCLING_VERSION="ROOT_0.7~dev" -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iinterpreter/llvm/src/tools/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/include -Iinterpreter/llvm/src/tools/cling/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -Wno-nested-anon-types -Wno-covered-switch-default -Wno-unused-local-typedef -fno-rtti -O3 -DNDEBUG -fno-exceptions -fno-rtti -std=c++11 -MD -MT interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -MF interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o.d -o interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -c /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:35: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:31: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:33: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:35: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora27/noimt.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/cxx17.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTargetInfo'; did you mean 'LLVMInitializeX86TargetInfo'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTarget'; did you mean 'LLVMInitializeX86Target'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTargetMC'; did you mean 'LLVMInitializeX86TargetMC'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: use of undeclared identifier 'LLVMInitializeNVPTXAsmPrinter'; did you mean 'LLVMInitializeX86AsmPrinter'?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Errors:

  • /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • ce/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

Warnings:

  • /home/sftnight/build/workspace/root-pullrequests-build/root/core/zstd/src/ZipZSTD.cxx:23:44: warning: large integer implicitly truncated to unsigned type [-Woverflow]

@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
See console output.

Errors:

  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(100,5): error C3861: 'LLVMInitializeNVPTXTargetInfo': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(101,5): error C3861: 'LLVMInitializeNVPTXTarget': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(102,5): error C3861: 'LLVMInitializeNVPTXTargetMC': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(103,5): error C3861: 'LLVMInitializeNVPTXAsmPrinter': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora29/python3.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@SimeonEhrig
Copy link
Contributor

@SimeonEhrig you said (in root-project/cling#284 (comment) )

I have removed the part of the code that requires changes to the clang base.

Yet the errors above seem to come from a missing llvm patch. Could you clarify?

I've removed any part that requires changes to the Clang base. The error occurs because the nvptx is not enabled. I'm not familiar with the root build process, so I need a little time to check it.

@SimeonEhrig
Copy link
Contributor

I see there is a mistake at the PR. The commit fe12679 is no longer needed.

@SimeonEhrig
Copy link
Contributor

I have developed a solution to enable the NVPTX backend in Root by default. I have also implemented a check in the CMakeLists.txt of Cling that throw an error if the NVPTX backend is not enabled. Unfortunately, I don't know how to push commits to this PR, so I forked your repo and modified the PR-284 branch: https://github.com/SimeonEhrig/root/tree/PR-284

Attention: I have removed the last commit of your branch.

@Axel-Naumann
Copy link
Member Author

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetInfo’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope; did you mean ‘LLVMInitializeX86Target’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope; did you mean ‘LLVMInitializeX86TargetMC’?
  • /build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope; did you mean ‘LLVMInitializeX86AsmPrinter’?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

  • FAILED: /usr/bin/ccache /usr/bin/c++ -DCLING_VERSION="ROOT_0.7~dev" -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iinterpreter/llvm/src/tools/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/include -Iinterpreter/llvm/src/tools/cling/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/tools/clang/include -Iinterpreter/llvm/src/include -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -Wno-nested-anon-types -Wno-covered-switch-default -Wno-unused-local-typedef -fno-rtti -O3 -DNDEBUG -fno-exceptions -fno-rtti -std=c++11 -MD -MT interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -MF interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o.d -o interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o -c /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:35: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:31: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:33: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:35: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora27/noimt.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/cxx17.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTargetInfo'; did you mean 'LLVMInitializeX86TargetInfo'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTarget'; did you mean 'LLVMInitializeX86Target'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: use of undeclared identifier 'LLVMInitializeNVPTXTargetMC'; did you mean 'LLVMInitializeX86TargetMC'?
  • /build/jenkins/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: use of undeclared identifier 'LLVMInitializeNVPTXAsmPrinter'; did you mean 'LLVMInitializeX86AsmPrinter'?

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora29/python3.
See console output.

Errors:

  • FAILED: interpreter/llvm/src/tools/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalCUDADeviceCompiler.cpp.o
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:5: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Errors:

  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:35: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:101:31: error: ‘LLVMInitializeNVPTXTarget’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:33: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:35: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
See console output.

Errors:

  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(100,5): error C3861: 'LLVMInitializeNVPTXTargetInfo': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(101,5): error C3861: 'LLVMInitializeNVPTXTarget': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(102,5): error C3861: 'LLVMInitializeNVPTXTargetMC': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\interpreter\cling\lib\Interpreter\IncrementalCUDADeviceCompiler.cpp(103,5): error C3861: 'LLVMInitializeNVPTXAsmPrinter': identifier not found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\cling\lib\Interpreter\obj.clingInterpreter.vcxproj]

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Errors:

  • /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:100:5: error: ‘LLVMInitializeNVPTXTargetInfo’ was not declared in this scope
  • /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:102:5: error: ‘LLVMInitializeNVPTXTargetMC’ was not declared in this scope
  • /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalCUDADeviceCompiler.cpp:103:5: error: ‘LLVMInitializeNVPTXAsmPrinter’ was not declared in this scope

Warnings:

  • /home/sftnight/build/workspace/root-pullrequests-build/root/core/zstd/src/ZipZSTD.cxx:23:44: warning: large integer implicitly truncated to unsigned type [-Woverflow]

@Axel-Naumann
Copy link
Member Author

Superseded by #4618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadura oshadura Awaiting requested review from oshadura

@vgvassilev vgvassilev Awaiting requested review from vgvassilev vgvassilev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Axel-Naumann @phsft-bot @SimeonEhrig