-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use suitable TmpltSpec for nondep member type names #8124
Use suitable TmpltSpec for nondep member type names #8124
Conversation
Starting build on |
Build failed on ROOT-fedora31/noimt. Errors:
And 4 more |
Build failed on ROOT-performance-centos8-multicore/default. Errors:
And 4 more |
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
And 5 more |
Build failed on ROOT-fedora30/cxx14. Errors:
And 5 more |
Build failed on mac11.0/cxx17. Errors:
|
Build failed on mac1014/python3. Errors:
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
And 4 more |
Build failed on windows10/cxx14. Errors:
And 11 more |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests:
And 23 more |
Build failed on mac1014/python3. Failing tests:
|
Build failed on windows10/cxx14. Failing tests: |
8d21457
to
a1ffcf2
Compare
Starting build on |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
Build failed on mac11.0/cxx17. Warnings:
And 1497 more Failing tests:
|
Starting build on |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
Build failed on mac11.0/cxx17. Failing tests: |
@phsft-bot build |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
Build failed on mac11.0/cxx17. Failing tests: |
@phsft-bot build |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
Build failed on mac11/cxx17. Failing tests: |
…ext: Instead of picking a "random" (the first) specialization when building the name of a non-dependent member type of a template, pick the one that corresponds to the "current" specialization. As CreateNestedNameSpecifierForScopeOf cannot know what's "current", this context needs to be passed down / propagated. Add a couple of asserts that the context is provided when needed, and is a template specialization that matches the type at hand. This fixes root-project#7955.
21471b7
to
43018de
Compare
Starting build on |
Moved to #16232 |
Before, cling used the first specialization, which is often incorrect. Instead pass the "current" specialization as context down to the relevant functions.