Automatically set wp_home and wp_siteurl
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
wp-sites-set-wp-home-siteurl-defaults
branch
2 times, most recently
from
85cb26d to
cb37349
Compare
Using the "dynamic" HTTP_HOST/SERVER_NAME is a good enough default. In the majority of cases users should not have to worry about setting these variables and overriding them. This also allows for a more seamless transition to HTTPS since there's one less place to configure or potentially forget. It also just reduces the chances of misconfiguration in general and a mismatch of values (site hosts and wp home/siteurl).
swalkinshaw
force-pushed
the
wp-sites-set-wp-home-siteurl-defaults
branch
from
cb37349 to
85eebc0
Compare
swalkinshaw
added a commit
that referenced
this pull request
May 7, 2016
#533 caused a regression in the cron job which runs `wp-cron.php`. Since `wp_home` and `wp_siteurl` were changed to use bash and PHP variables, the cron command wouldn't work. The solution is to avoid this and use WP-CLI's `cron` command for running due cron events.
|
With this change nothing works. All my Wordpress links etc. have literal Edit: Disregard. Bad version of bedrock |
swalkinshaw
added a commit
that referenced
this pull request
Jul 28, 2016
#533 caused a regression in the cron job which runs `wp-cron.php`. Since `wp_home` and `wp_siteurl` were changed to use bash and PHP variables, the cron command wouldn't work. The solution is to avoid this and use WP-CLI's `cron` command for running due cron events.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "dynamic" HTTP_HOST/SERVER_NAME is a good enough default. In
the majority of cases users should not have to worry about setting these
variables and overriding them.
This also allows for a more seamless transition to HTTPS since there's
one less place to configure or potentially forget. It also just reduces
the chances of misconfiguration in general and a mismatch of values
(site hosts and wp home/siteurl).