Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize installed Apt packages #735

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Conversation

nathanielks
Copy link
Contributor

@nathanielks nathanielks commented Jan 16, 2017

This adds a few new variables:

  • apt_packages_default
  • apt_packages_custom
  • apt_packges_install

If a user wishes to install additional apt packages, they simply need to add items to the custom_apt_packages variable:

apt_packages_custom:
  - nfs-utils

@retlehs
Copy link
Member

retlehs commented Jan 16, 2017

  • default_apt_packages -> apt_packages_default
  • custom_apt_packages -> apt_packages_custom
  • install_apt_packges -> apt_packages_install

- libnss-myhostname
- ghostscript
- imagemagick
- poppler-utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you snuck some of your custom ones in here :trollface:

@swalkinshaw swalkinshaw modified the milestone: 1.0.0 Jan 17, 2017
Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Can you add changelog entry?

@swalkinshaw swalkinshaw force-pushed the customize-apt-packages branch from c8f2eb9 to 2855c99 Compare January 24, 2017 00:58
@swalkinshaw swalkinshaw force-pushed the customize-apt-packages branch from 2855c99 to 12ae0c9 Compare January 24, 2017 00:58
@swalkinshaw swalkinshaw merged commit 54ab64c into master Jan 24, 2017
@swalkinshaw swalkinshaw deleted the customize-apt-packages branch January 24, 2017 01:42
@hamedb89
Copy link

I am having problems with this commit.

TASK [fail2ban : ensure fail2ban starts on a fresh reboot] *********************
System info:
  Ansible 2.0.2.0; Vagrant 1.8.6; Darwin
  Trellis at "Add `apt_packages_custom` to customize Apt packages"
---------------------------------------------------
error importing module in /usr/local/lib/python2.7/site-
packages/ansible/modules/core/system/systemd.py, expecting format like 'from
ansible.module_utils.<lib name> import *'
fatal: [default]: FAILED! => {"failed": true}

NO MORE HOSTS LEFT *************************************************************
	to retry, use: --limit @/Users/hamedbahrami/vagrant/design-factory.de/trellis/dev.retry

PLAY RECAP *********************************************************************
default                    : ok=6    changed=0    unreachable=0    failed=1   

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants