Check Ansible version before Ansible validates task attributes #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Avoids "ERROR! ‘check_mode’ is not a valid attribute for a Task" which occurs for Ansible lt 2.2. Ansible validates task attributes before running a playbook and before loading callback plugins, so a vars plugin appeared to be the only option for intercepting the error with a version check and message.
fullyint
force-pushed
the
ansible-version-check
branch
from
db3b369 to
f5cc228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids
ERROR! 'check_mode' is not a valid attribute for a Taskfor Ansible < 2.2 (example).The challenge is that Ansible validates task attributes before running a playbook, before the current version check can run, and even before the callback plugin is processed.
A vars plugin will load before Ansible validates task attributes, so it appeared to be the only option for performing a version check and helpful "please upgrade" message.
This PR adds back a vars plugin as a bit of a hack for the sake of the Ansible version check. Trellis formerly had a vars plugin (removed in #684 and #707).
Edit: Modeled after Ansible's
version_comparetest.