Update h5bp #876
Merged
Update h5bp #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrufus
force-pushed
the
update-h5bp
branch
from
ff051b1 to
c925838
Compare
swalkinshaw
reviewed
Sep 4, 2017
roles/nginx/templates/nginx.conf.j2
Outdated
| error_log {{ nginx_logs_root }}/error.log warn; | ||
| {% endblock %} | ||
|
|
||
| {% block pid %} | ||
| # The file storing the process ID of the main process | ||
| pid /run/nginx.pid; | ||
| # Default: nginx.pid | ||
| pid /var/run/nginx.pid; |
There was a problem hiding this comment.
Was this change from h5bp? I believe it should stay as /run. It's the "newer" location and /var/run is symlinked to it.
There was a problem hiding this comment.
There was a problem hiding this comment.
So /run is the correct one?
There was a problem hiding this comment.
From what I can tell it is. So let's keep it as /run
tangrufus
force-pushed
the
update-h5bp
branch
from
c925838 to
5e944b2
Compare
|
Rest looks good, thanks 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I can't get ssl.no-default to work. Thus, I omitted it.