Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Be smart about detecting if a review has been submitted #4

Open
sckott opened this issue Mar 22, 2016 · 1 comment
Open

Be smart about detecting if a review has been submitted #4

sckott opened this issue Mar 22, 2016 · 1 comment

Comments

@sckott
Copy link
Contributor

sckott commented Mar 22, 2016

e.g., here ropensci/software-review#23 pinged using both reviewers handles, but one had already submitted a review, but other hadn't
sckott added a commit that referenced this issue Mar 22, 2016
@sckott
#4 fixes to detect if a review already submitted, not super smart, bu…
2fe3f00 
…t something
@sckott sckott mentioned this issue Jun 1, 2016
Closed
@sckott
Copy link
Contributor Author

sckott commented Jun 1, 2016

changing this to look for whether reviews are shorter or longer than 1300 characters. This is the shortest review so far.

another strategy to make sure we aren't pinging people about unsubmitted reviews, when they have in fact submitted, is to make sure we apply the review-in-awaiting-changes label (https://github.com/ropensci/onboarding/labels/review-in-awaiting-changes) asap after review submitted, as we then easily know review is in

sckott added a commit that referenced this issue Jun 1, 2016
@sckott
#4 change revs_not_reviewed method to accept as a review a body great…
f3ef3bd 
…er than 1300 chars

also changed our internal setting of HEYTHERE_POST_REVIEW_TOGGLE to false, but switched code internally
as it makes more ssense this way, - anyway, were not doing post review pings to authors still
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sckott