Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several maintainers #109

Closed
maelle opened this issue Apr 23, 2018 · 8 comments
Closed

Several maintainers #109

maelle opened this issue Apr 23, 2018 · 8 comments
Assignees
Milestone

Comments

@maelle
Copy link
Member

maelle commented Apr 23, 2018

@cboettig is "Can have only single maintainer, not list" a codemeta definition?

If not I'd like to change parse_people to be able to parse https://bioconductor.org/packages/release/bioc/html/a4.html as is (two maintainers among which only one is an author, two authors among which one is a maintainer).

@maelle maelle added this to the 0.1.6 release milestone Apr 23, 2018
maelle pushed a commit that referenced this issue Apr 23, 2018
@cboettig
Copy link
Member

That's just a CRAN thing. (Actually I thought it was a R CMD check thing, but apparently not!) CodeMeta is fine with multiple maintainers (multiple anything), so we should support that too.

cboettig pushed a commit that referenced this issue Apr 23, 2018
* add pre-commit hook for DESCRIPTION vs codemeta.json

* oops had forgotten the dependencies 😱

* had also forgotten to import the function

* puts the code in the right place and documents what the first call to write_codemeta will do

* add rOpenSci and myself as authors

* remove MIT licence

* change licence

* add that the code is GPL-3

* replaces devtools with usethis where possible

* mostly French snobism 😉

* add uses_git origin

* cf #62

* #62

* only adds hook once!

* start using desc cf #41

* various fixes

* better example?

* document

* removes reference to deleted function

* cf #63

* cf #64, parses more possible roles

* updates codemeta.json in particular more people/orgs appear

* start work on opinions cf #76

* document

* oops

* oops again

* gives opinion when verbose=TRUE and otherwise just uses robust code

* cleans up tests

* more tests of plain authors&maintainer

* work on tests

* corrects documentation

* better if the pkg exists 😁

* update codemeta

* adds a message to get a devtools release question

* fix?

* new try

* removes httr dependency in favor of crul cf #83

* checks URLs in DESCRIPTION cf #68

* oops fixes test

* uses dev version of jsonld

* adds coercion to character to repair bug introduced by jsonld new version cf #88

* clean up cache

* yay encoding

* close #84 by deleting now useless licences.R file

* appveyor

* oh, Appveyor

* start filling NEWS.md

* better checks when several URLs

* more space

* generate review metadata cf #23

* oops

* cf #63

* @jeroen said that this might help 🙏

* thanks again @jeroen

* test on patched R version

* CRAN and Bioconductor links for dependencies cf #81

* add tests of dependencies URL creation

* add canonic URL for the package itself cf #81

* borrows jsonlite code cf #84

* makes it a bit more specific

* badge parsing cf #130

* uses badge parsing function in guess_metadata

* opinions about README cf 98

* add check of provider cf #81

* oops

* oops again

* R CMD Check NOTEs

* oops

* update contributor list cf #95

* several relatedLinks cf #99

* add the URL only once

* oops repairs test

* update NEWS

* add ability to provide relatedLink for packages installed from CRAN or Bioconductor

* add link to commit if available

* only one maintainer currently cf #109

* oops this was wrong!

* mmmh there was a mistake here

* Travis fix?

* remotes cf #96

* Travis fix?

* export the badge extraction function cf #107 and update docs and correct a test

* status as URL cf #102

* now one can extract lifecycle status

* not only Travis CI as contIntegration cf #111

* update NEWs

* update NEWS

* repairs handling of additional terms cf #112 and adds corresponding test

* correct test
@maelle maelle mentioned this issue Apr 23, 2018
@cboettig
Copy link
Member

@maelle what needs to change here -- is this just documentation or do we need to vectorize the function so it can take multiple entries?

@maelle
Copy link
Member Author

maelle commented Apr 23, 2018

The code https://github.com/ropensci/codemetar/blob/master/R/codemeta_description.R#L104

Tests I think? See which ones are broken by changing the code linked above 🙈

Docs I don't know, I have nearly not touched docs

@maelle
Copy link
Member Author

maelle commented Apr 23, 2018

And maybe the maintainer variable should be called maintainers

@cboettig
Copy link
Member

The R variable name doesn't matter, but recall all the role fields in codemeta are singular by definition (author, editor, maintainer, funder etc), so we should probably stick with that (I see the R code uses authors as an internal variable, but it becomes author in the actual list object anyway).

Feel free to swap this out to permit multiple maintainers; otherwise, I'll try and get to it later this week or so... crazy end of semester time here...

@maelle
Copy link
Member Author

maelle commented Apr 23, 2018

I can solve that on Wed and even make the release, then you'd just need to confirm the CRAN submission?

@cboettig
Copy link
Member

sweet, sounds like a plan!

@maelle
Copy link
Member Author

maelle commented Apr 23, 2018

Cool then "someone" will submit the pkg on Wed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants