Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Twitter link and update Adam's credentials :-) #843

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 27, 2024

Fix #842

Copy link
Member

@adamhsparks adamhsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Maëlle, this should work well, I don't plan to change the URL of my webpage.

@maelle maelle requested a review from mpadge September 27, 2024 06:57
@maelle
Copy link
Member Author

maelle commented Sep 27, 2024

Thanks both!

@maelle maelle merged commit af1ed5c into main Sep 27, 2024
2 checks passed
@maelle maelle deleted the maelle-patch-5 branch September 27, 2024 08:39
@Lextuga007
Copy link

Does this get filtered into the translation as it still appears

Como antiguo revisor y autor de paquetes, [Adam Sparks](https://adamhsparks.netlify.app/) [escribió lo siguiente](https://twitter.com/adamhsparks/status/898132036451303425) "\[escribe\] una buena crítica de la estructura del paquete y de las mejores prácticas de escritura de código. Si sabes cómo hacer algo mejor, dímelo. Como desarrollador es fácil pasar por alto oportunidades de documentación, pero como al hacer la revisión, tienes una visión diferente. Eres una persona que puede dar devolución. ¿Qué no está claro en el paquete? ¿Cómo puede hacerse más claro? Si lo utilizas por primera vez, ¿es fácil? ¿Conoces otro paquete R que quizás debería utilizar? ¿O hay alguno que esté utilizando y que quizás no debería? Si puedes contribuir al paquete, ofrécete".
?

@maelle
Copy link
Member Author

maelle commented Jan 31, 2025

Good catch! ccd0482

@maelle
Copy link
Member Author

maelle commented Jan 31, 2025

also removed from #818

Thanks so much @Lextuga007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Linksoftwarereview_reviewer.Rmd
4 participants