Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R-CMD-check workflow #24

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add R-CMD-check workflow #24

merged 2 commits into from
Aug 12, 2024

Conversation

jrdnbradford
Copy link
Collaborator

I found this repo through the rOpenSci newletter and see there's an issue (#23) for maintaining and volunteering. I wouldn't mind doing a few things to spruce this up a bit, @maelle.

For starters, this adds a basic R-CMD-check workflow that should make it easier to integrate and test changes.

@maelle
Copy link
Member

maelle commented Aug 12, 2024

Thank you! Do you want to keep adding me as a reviewer (fine with me) or would you like to get write access?

@maelle maelle merged commit ec6cabe into ropensci:master Aug 12, 2024
@maelle
Copy link
Member

maelle commented Aug 12, 2024

(I was on vacation, usually it shouldn't take me weeks to respond 🙂)

@jrdnbradford
Copy link
Collaborator Author

@maelle no worries! I think write access would be great. Thank you!

@maelle
Copy link
Member

maelle commented Aug 13, 2024

If you decide to become the maintainer, please ping me again so I might increase your access once again 😉

@jrdnbradford jrdnbradford self-assigned this Aug 19, 2024
@jrdnbradford
Copy link
Collaborator Author

@maelle thanks for the access. I resolved several issues and made quite a few updates that included bug fixes, new datasets, package infrastructure updates, and docs, resulting in the release of v0.3.0.

I don't think I'm the right person to be the maintainer of this particular repo, but I hope my changes will lower the barrier to someone else accepting that role.

You can remove my write access if you'd like.

Thanks! 🤖

@maelle
Copy link
Member

maelle commented Aug 20, 2024

Thank you!!

@maelle
Copy link
Member

maelle commented Aug 20, 2024

@jrdnbradford even if you don't want to become the maintainer, you'd be welcome to join our slack workspace. If that's interesting to you, please share your email address with me here or at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants