Allow bounds as objects of class Spatial #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r formatting changes and remove rm call that was not needed.
…call to as.vector
… so can't rely on sf::st_bbox for Spatial)
|
Merging this one as it looks good to me and I can see it being very useful. |
stragu
added a commit
that referenced
this pull request
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
This PR builds upon the chunk added in c591d0d by Martin Jung. Only addition is to allow objects of class Spatial (essentially from the {sp} package) also.
This also removes the call to
as.vectoras this is not needed. A few code formatting changes also.