fix #372 fix arc2 internal function - along with remove sf package fr…

…om suggests

sf was in arc2 test, but not needed AFAICT

DESCRIPTION

@@ -59,7 +59,6 @@ Suggests:
     raster,
     leaflet,
     rgdal,
-    sf,
     rmarkdown,
     purrr,
     ggmap,

R/arc2.R

@@ -58,7 +58,8 @@ arc2 <- function(date, box = NULL, ...) {
 }
 
 filter_split <- function(x, box) {
-  df <- dplyr::filter(x, dplyr::between(lon, 9, 10), dplyr::between(lat, 4, 5))
+  df <- dplyr::filter(x, dplyr::between(lon, box[1], box[3]),
+    dplyr::between(lat, box[2], box[4]))
   split(df, df$date)
 }
 

tests/fixtures/arc2_bounding_box.yml

@@ -6,7 +6,7 @@ http_interactions:
       encoding: ''
       string: ''
     headers:
-      User-Agent: libcurl/7.64.1 r-curl/4.3 crul/0.9.0
+      User-Agent: libcurl/7.72.0 r-curl/4.3 crul/1.0.0
       Accept-Encoding: gzip, deflate
       Accept: application/json, text/xml, application/xml, */*
       Authorization: Basic anonymous:[email protected]
@@ -22,16 +22,16 @@ http_interactions:
       encoding: UTF-8
       file: yes
       string: ../files/daily_clim.bin.19830101.gz
-  recorded_at: 2020-05-28 18:12:10 GMT
-  recorded_with: vcr/0.5.4, webmockr/0.6.2
+  recorded_at: 2020-10-05 15:29:10 GMT
+  recorded_with: vcr/0.5.4, webmockr/0.7.0
 - request:
     method: get
     uri: ftp://ftp.cpc.ncep.noaa.gov/fews/fewsdata/africa/arc2/bin/daily_clim.bin.19900205.gz
     body:
       encoding: ''
       string: ''
     headers:
-      User-Agent: libcurl/7.64.1 r-curl/4.3 crul/0.9.0
+      User-Agent: libcurl/7.72.0 r-curl/4.3 crul/1.0.0
       Accept-Encoding: gzip, deflate
       Accept: application/json, text/xml, application/xml, */*
       Authorization: Basic anonymous:[email protected]
@@ -47,5 +47,5 @@ http_interactions:
       encoding: UTF-8
       file: yes
       string: ../files/daily_clim.bin.19900205.gz
-  recorded_at: 2020-05-28 18:12:10 GMT
-  recorded_with: vcr/0.5.4, webmockr/0.6.2
+  recorded_at: 2020-10-05 15:29:10 GMT
+  recorded_with: vcr/0.5.4, webmockr/0.7.0

tests/testthat/test-arc2.R

@@ -38,7 +38,6 @@ test_that("arc2 - bounding box works", {
   skip_on_cran()
   skip_on_ci()
   skip_if_government_down()
-  skip_if_not_installed("sf")
 
   vcr::use_cassette("arc2_bounding_box", {
     box <- c(xmin = 9, ymin = 4, xmax = 10, ymax = 5)